Skip to content

Stop copying LogicalPlan and Exprs in PushDownFilter (4%-6% faster planning) #10444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 17, 2024
Merged

Stop copying LogicalPlan and Exprs in PushDownFilter (4%-6% faster planning) #10444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
891d415
Stop copying LogicalPlan and Exprs in `PushDownFilter`
alamb May 9, 2024
a44fbc5
Merge remote-tracking branch 'apache/main' into alamb/push_down_filter
alamb May 14, 2024
7e02ae1
Merge remote-tracking branch 'apache/main' into alamb/push_down_filter
alamb May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions datafusion/expr/src/logical_plan/plan.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2407,6 +2407,16 @@ pub enum Distinct {
On(DistinctOn),
}

impl Distinct {
/// return a reference to the nodes input
pub fn input(&self) -> &Arc<LogicalPlan> {
match self {
Distinct::All(input) => input,
Distinct::On(DistinctOn { input, .. }) => input,
}
}
}

/// Removes duplicate rows from the input
#[derive(Clone, PartialEq, Eq, Hash)]
pub struct DistinctOn {
Expand Down
Loading