Move coalesce function from math to core #10201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xxxuuu <[email protected]>
|
Thank you for the contribution @xxxuuu ❤️ |
alamb
approved these changes
Apr 23, 2024
|
Hi @xxxuuu -- it looks like there is a small CI failure -- https://github.com/apache/datafusion/actions/runs/8803139105/job/24166156315?pr=10201 |
Signed-off-by: xxxuuu <[email protected]>
Thank. I have fixed it! |
ccciudatu
pushed a commit
to hstack/arrow-datafusion
that referenced
this pull request
Apr 26, 2024
* Move coalesce function from math to core Signed-off-by: xxxuuu <[email protected]> * Make `cargo doc` happy Signed-off-by: xxxuuu <[email protected]> --------- Signed-off-by: xxxuuu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
closes #10174
Rationale for this change
The current location of the coalesce function isn't really the best place for it.
What changes are included in this PR?
Move coalesce function from math to core
Are these changes tested?
All unit tests, sqllogictests and integration tests have passed.
Are there any user-facing changes?
No.