Avoid cloning in log::simplify and power::simplify
#10086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comphead
approved these changes
Apr 16, 2024
Omega359
reviewed
Apr 16, 2024
| // log(base, number) | ||
| let num_args = args.len(); | ||
| if args.len() > 2 { | ||
| return plan_err!("Expected log to have 1 or 2 arguments, got {num_args}"); |
There was a problem hiding this comment.
should this be an exec error to match similar patterns elsewhere?
There was a problem hiding this comment.
lets fix it in follow up. tbh we should unify error messaging for all builtin functions
There was a problem hiding this comment.
I think the idea here is that simplify gets called as part of planning (not execution) so planning makes sense to me. Though I am not sure what practical difference it makes in this case 🤔
comphead
reviewed
Apr 16, 2024
Co-authored-by: comphead <[email protected]>
…n into alamb/less_cloning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes tinfoil-knight#1
Closes #10003
Follow on to #9983
Rationale for this change
in #9983 @tinfoil-knight ported over exp/power to be
ScalarUDFs 🙏 -- while reviewing the PR I noticed that we could reduce some clones and worked up the code in tinfoil-knight#1What changes are included in this PR?
log::simplifyandpower::simplifyAre these changes tested?
Are there any user-facing changes?