Add tests for create table

apache · Sep 29, 2024 · 88e90d2 · 88e90d2
1 parent 170f239
commit 88e90d2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/datafusion/core/src/catalog_common/mod.rs b/datafusion/core/src/catalog_common/mod.rs
@@ -187,6 +187,9 @@ pub fn resolve_table_references(
             DFStatement::CreateExternalTable(table) => {
                 let idents: Vec<Ident> = table.name.split('.').map(Ident::from).collect();
                 visitor.relations.insert(ObjectName(idents));
+                visitor
+                    .relations
+                    .insert(ObjectName(vec![Ident::from(table.name.as_str())]));
             }
             DFStatement::CopyTo(CopyToStatement { source, .. }) => match source {
                 CopyToSource::Relation(table_name) => {

diff --git a/datafusion/sql/tests/sql_integration.rs b/datafusion/sql/tests/sql_integration.rs
@@ -1913,6 +1913,13 @@ fn create_external_table_with_pk() {
     quick_test(sql, expected);
 }
 
+#[test]
+fn create_external_table_wih_schema() {
+    let sql = "CREATE EXTERNAL TABLE staging.foo STORED AS CSV LOCATION 'foo.csv'";
+    let expected = "CreateExternalTable: Partial { schema: \"staging\", table: \"foo\" }";
+    quick_test(sql, expected);
+}
+
 #[test]
 fn create_schema_with_quoted_name() {
     let sql = "CREATE SCHEMA \"quoted_schema_name\"";
@@ -1949,7 +1956,7 @@ fn create_external_table_csv_no_schema() {
 }
 
 #[test]
-fn create_external_table_with_compression_type() {
+fn create_external_table_with_compression_typet() {
     // positive case
     let sqls = vec![
         "CREATE EXTERNAL TABLE t(c1 int) STORED AS CSV LOCATION 'foo.csv.gz' OPTIONS ('format.compression' 'gzip')",