Skip to content

Commit

Permalink
Remove deprecated from_plan function (#12265)
Browse files Browse the repository at this point in the history
* Remove deprecated from_plan function

Deprecated since 31.0.0.

* empty
  • Loading branch information
findepi authored Aug 31, 2024
1 parent 88dd305 commit 442d9bf
Showing 1 changed file with 0 additions and 31 deletions.
31 changes: 0 additions & 31 deletions datafusion/expr/src/utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -679,37 +679,6 @@ where
err
}

/// Returns a new logical plan based on the original one with inputs
/// and expressions replaced.
///
/// The exprs correspond to the same order of expressions returned by
/// `LogicalPlan::expressions`. This function is used in optimizers in
/// the following way:
///
/// ```text
/// let new_inputs = optimize_children(..., plan, props);
///
/// // get the plans expressions to optimize
/// let exprs = plan.expressions();
///
/// // potentially rewrite plan expressions
/// let rewritten_exprs = rewrite_exprs(exprs);
///
/// // create new plan using rewritten_exprs in same position
/// let new_plan = from_plan(&plan, rewritten_exprs, new_inputs);
/// ```
///
/// Notice: sometimes [from_plan] will use schema of original plan, it don't change schema!
/// Such as `Projection/Aggregate/Window`
#[deprecated(since = "31.0.0", note = "use LogicalPlan::with_new_exprs instead")]
pub fn from_plan(
plan: &LogicalPlan,
expr: &[Expr],
inputs: &[LogicalPlan],
) -> Result<LogicalPlan> {
plan.with_new_exprs(expr.to_vec(), inputs.to_vec())
}

/// Create field meta-data from an expression, for use in a result set schema
pub fn exprlist_to_fields<'a>(
exprs: impl IntoIterator<Item = &'a Expr>,
Expand Down

0 comments on commit 442d9bf

Please sign in to comment.