Skip to content

Commit

Permalink
reduce calling of is_null.
Browse files Browse the repository at this point in the history
  • Loading branch information
Rachelint committed Oct 4, 2024
1 parent 0eda17a commit 1ea3803
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ impl<T: ArrowPrimitiveType, const NULLABLE: bool> GroupColumn
// In nullable path, we should check if both `exist row` and `input row`
// are null/not null
let is_exist_null = self.nulls.is_null(lhs_row);
let null_match = self.nulls.is_null(lhs_row) == array.is_null(rhs_row);
let null_match = is_exist_null == array.is_null(rhs_row);
if !null_match {
// If `is_null`s in `exist row` and `input row` don't match, return not equal to
return false;
Expand Down

0 comments on commit 1ea3803

Please sign in to comment.