Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README How to develop section now also works on Apple M1 #940

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

drauschenbach
Copy link
Contributor

Which issue does this PR close?

Closes #939.

Rationale for this change

README previously contained instructions that only worked on Linux.

What changes are included in this PR?

The default Conda environment file no longer depends on CUDA Toolkit or cuDF. An alternative environment file is made available for CUDA support.

Are there any user-facing changes?

For Apple users, the README will start working. For Linux users where GPUs are supported, the old instructions will not install CUDA support, but alternative instructions are provided to get the old behavior.

@drauschenbach
Copy link
Contributor Author

Verification on an Apple M1

$ micromamba env create -f ./conda/environments/datafusion-dev.yaml -n datafusion-dev
...
Transaction finished

To activate this environment, use:

    micromamba activate datafusion-dev
$ micromamba activate datafusion-dev
$ maturin develop
...
 Installed datafusion-42.0.0
$ python3 -m pytest   
================================================================== test session starts ===================================================================
platform darwin -- Python 3.12.7, pytest-8.3.3, pluggy-1.5.0
rootdir: /Users/davidr/workspaces/drauschenbach/datafusion-python
configfile: pyproject.toml
collected 465 items                                                                                                                                      

python/tests/test_aggregation.py ..................................................................................                                [ 17%]
python/tests/test_catalog.py .                                                                                                                     [ 17%]
python/tests/test_config.py ...                                                                                                                    [ 18%]
python/tests/test_context.py .....................ss......................                                                                         [ 28%]
python/tests/test_dataframe.py ...............................................................................ssss............................     [ 52%]
python/tests/test_expr.py ..........                                                                                                               [ 54%]
python/tests/test_functions.py ................................................................................................................... [ 78%]
.......................                                                                                                                            [ 83%]
python/tests/test_imports.py .....                                                                                                                 [ 84%]
python/tests/test_indexing.py ..                                                                                                                   [ 85%]
python/tests/test_input.py .                                                                                                                       [ 85%]
python/tests/test_plans.py .                                                                                                                       [ 85%]
python/tests/test_sql.py .........................x...xxxx........                                                                                 [ 94%]
python/tests/test_store.py .                                                                                                                       [ 94%]
python/tests/test_substrait.py ...                                                                                                                 [ 95%]
python/tests/test_udaf.py .....                                                                                                                    [ 96%]
python/tests/test_udf.py ...                                                                                                                       [ 97%]
python/tests/test_udwf.py ............                                                                                                             [ 99%]
python/tests/test_wrapper_coverage.py .                                                                                                            [100%]

======================================================= 454 passed, 6 skipped, 5 xfailed in 2.89s ========================================================

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andygrove andygrove merged commit cbe28cb into apache:main Nov 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "How to develop" README instructions for Conda don't work on an Apple M1
2 participants