Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove XFAIL from passing tests #884

Merged
merged 3 commits into from
Sep 28, 2024

Conversation

Michael-J-Ward
Copy link
Contributor

@Michael-J-Ward Michael-J-Ward commented Sep 26, 2024

Rationale for this change

These tests are now passing, so I've removed the xfail from them.

pyarrow.parquet does not preserve timestamp[s] data type roundtrip between write and read.

apache/arrow#41382

Are there any user-facing changes?

No.

@Michael-J-Ward Michael-J-Ward changed the title Xpass tests chore: remove XFAIL from passing tests Sep 27, 2024
@Michael-J-Ward Michael-J-Ward marked this pull request as ready for review September 27, 2024 19:15
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks @Michael-J-Ward

@andygrove andygrove merged commit 2df33d3 into apache:main Sep 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants