Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add guidelines on separating python and rust code #860

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

Michael-J-Ward
Copy link
Contributor

Which issue does this PR close?

Closes #779.

Rationale for this change

The introduction of the python wrappers necessitates some guideline for separating code.

What changes are included in this PR?

A section is added to the contributor guide.

Are there any user-facing changes?

No.

@Michael-J-Ward Michael-J-Ward marked this pull request as ready for review September 6, 2024 22:54
Copy link
Contributor

@mesejo mesejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timsaucer timsaucer merged commit 4ea0032 into apache:main Sep 7, 2024
15 checks passed
emgeee pushed a commit to probably-nothing-labs/datafusion-python that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clarify separation between rust code and python wrappers
3 participants