Bind SQLOptions and relative ctx method #567 #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomorebecchi
force-pushed
the
main
branch
from
d4a48d2
to
aaa4bdd
Compare
|
Hi @andygrove, I have rebased my commit to fix conflicts with upstream and improved the test cases. Please let me know if there's anything else you would like me to improve! Thanks a lot |
andygrove
approved these changes
Apr 13, 2024
There was a problem hiding this comment.
Thanks @giacomorebecchi! This is a great first contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #567.
What changes are included in this PR?
Are there any user-facing changes?
Yes, the user can now instantiate a SQLOptions class and use inside the newly bound method
sql_with_options.Final remark
This is my first open source contribution, so I apologise in advance if there is any mistake in the contribution style!