Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isnan and iszero #495

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Add isnan and iszero #495

merged 4 commits into from
Sep 12, 2023

Conversation

judahrand
Copy link
Contributor

Which issue does this PR close?

This builds on top of #491 and partially resolves #463.

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@viirya viirya mentioned this pull request Sep 11, 2023
src/functions.rs Outdated Show resolved Hide resolved
@viirya
Copy link
Member

viirya commented Sep 11, 2023

#491 was merged. Can you rebase this?

@judahrand
Copy link
Contributor Author

@viirya Done

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @judahrand and @viirya

@andygrove andygrove merged commit beabf26 into apache:main Sep 12, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing scalar functions
3 participants