Revert "build(deps): bump arduino/setup-protoc from 1 to 2 (#452)" #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 944b1c9.
|
The step |
|
cc @alamb @andygrove |
alamb
approved these changes
Sep 8, 2023
|
I don't know a whole lot about this repo, but the change seems reasonable to me |
andygrove
approved these changes
Sep 8, 2023
|
Thank you @alamb @andygrove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 944b1c9.
Which issue does this PR close?
Closes #472.
Rationale for this change
This follows the suggestion from arduino/setup-protoc#85. Based on it, setup-protoc@v2 is for v21.0. We should setup-protoc@v1.
What changes are included in this PR?
Are there any user-facing changes?