Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isnan scalar function #471

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions datafusion/tests/test_functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ def test_math_functions():
f.sinh(col_v),
f.tanh(col_v),
f.factorial(literal(6)),
f.isnan(col_nav),
)
batches = df.collect()
assert len(batches) == 1
Expand Down Expand Up @@ -185,6 +186,7 @@ def test_math_functions():
np.testing.assert_array_almost_equal(result.column(32), np.sinh(values))
np.testing.assert_array_almost_equal(result.column(33), np.tanh(values))
np.testing.assert_array_almost_equal(result.column(34), math.factorial(6))
np.testing.assert_array_almost_equal(result.column(35), np.isnan(na_values))


def test_string_functions(df):
Expand Down
7 changes: 6 additions & 1 deletion src/functions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,11 @@
scalar_function!(floor, Floor);
scalar_function!(gcd, Gcd);
scalar_function!(initcap, InitCap, "Converts the first letter of each word to upper case and the rest to lower case. Words are sequences of alphanumeric characters separated by non-alphanumeric characters.");
scalar_function!(
isnan,
Isnan,

Check failure on line 235 in src/functions.rs

View workflow job for this annotation

GitHub Actions / test-matrix (3.10, stable)

no variant or associated item named `Isnan` found for enum `datafusion_expr::BuiltinScalarFunction` in the current scope
"Returns true if a given number is +NaN or -NaN otherwise returns false."
);
scalar_function!(lcm, Lcm);
scalar_function!(left, Left, "Returns first n characters in the string, or when n is negative, returns all but last |n| characters.");
scalar_function!(ln, Ln);
Expand All @@ -247,7 +252,7 @@
scalar_function!(
nanvl,
Nanvl,
"Computes the MD5 hash of the argument, with the result written in hexadecimal."
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function description was copied from MD5 previously, I think.

"Returns x if x is not NaN otherwise returns y."
);
scalar_function!(octet_length, OctetLength, "Returns number of bytes in the string. Since this version of the function accepts type character directly, it will not strip trailing spaces.");
scalar_function!(pi, Pi);
Expand Down
Loading