Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conda build/host deps to avoid overlinking issues #438

Closed
wants to merge 2 commits into from

Conversation

charlesbluca
Copy link
Contributor

Which issue does this PR close?

n/a

Rationale for this change

Our conda nightly builds emit some warnings around overlinking:

WARNING (datafusion,lib/python3.11/site-packages/datafusion/_internal.abi3.so): Needed DSO lib/liblzma.so.5 found in ['xz']
WARNING (datafusion,lib/python3.11/site-packages/datafusion/_internal.abi3.so): .. but ['xz'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
WARNING (datafusion,lib/python3.11/site-packages/datafusion/_internal.abi3.so): Needed DSO lib/libgcc_s.so.1 found in ['libgcc-ng']
WARNING (datafusion,lib/python3.11/site-packages/datafusion/_internal.abi3.so): .. but ['libgcc-ng'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)

That seem to be due to leaving out some build/host requirements that should be explicitly specified. This PR does this using the same approach taken in conda-forge/staged-recipes#23386 to resolve overlinking issues in a similar maturin project.

What changes are included in this PR?

Adds Rust / C compilers to build deps to resolve the libgcc_s.so.1 dependency, and xz to the host deps to resolve the liblzma.so.5 dependency

Are there any user-facing changes?

n/a

@charlesbluca
Copy link
Contributor Author

Closing this out in favor of #350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant