Fix Ignored RootNS #1367
Open
Fix Ignored RootNS #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- currently we find the root element using only the local name of an element, this can result in ambiguous roots and an error if you have an element with no namespace and one with a namespace. This PR fixes that by searching using the qname instead - add search for qname option if no namespace is specified, because there might still be an unambiguous root element within a namespace, the user just opted not to specify it DAFFODIL-2947
mbeckerle
approved these changes
Nov 7, 2024
| if (possibleRoots.length == 1) { | ||
| possibleRoots.head | ||
| } else { | ||
| val qn = RefQName(None, rootElementName, NoNamespace) |
There was a problem hiding this comment.
Add some comments explaining the rationale here. E.g.,
It's ambiguous what root element, and no namespace URI was provided.
So we assume not specifying a namespace URI may mean the intention
was to choose the root that it is in No Namespace.
If there is no such, then the diagnostic will encourage user to specify
the namespace explicitly.
| <tdml:testSuite suiteName="theSuiteName" xmlns:ex={example} xmlns:tdml={tdml} xmlns:dfdl={ | ||
| dfdl | ||
| } xmlns:xsd={xsd} xmlns:xs={xsd} xmlns:xsi={xsi}> | ||
| <tdml:parserTestCase name="test1" root="data" rootNS="" model="/test/tdml/chameleon-schema1.dfdl.xsd"> |
There was a problem hiding this comment.
Maybe rename test to reflect that rootNS is being used to specify no namespace. It's not only multiple root candidates but that one of them is no namespace, and this illustrates how to specify that.
- add doc comment - update test names DAFFODIL-2947
- use Schemas.searchGlobalElementDecl instead of duplicating effort DAFFODIL-2947
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DAFFODIL-2947