Improve diagnostic in TDML Runner #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbeckerle
commented
Nov 1, 2024
daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala
Outdated
Show resolved
Hide resolved
olabusayoT
approved these changes
Nov 1, 2024
stevedlawrence
approved these changes
Nov 4, 2024
daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala
Show resolved
Hide resolved
Note that this change enforces the syntax of TDML better. The dfdlInfoset element used to tolerate having spurious text in it, so long as it also had a root element. Two TDML files had to be fixed in Daffodil. If TDML files in schema projects have these spurious characters that were formerly ignored, this change will break those tests. DAFFODIL-533
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to fix an ancient bug.
Note that this change enforces the syntax of TDML better.
The dfdlInfoset element used to tolerate having spurious text in it, so long as it also had a root element.
Two TDML files had to be fixed in Daffodil.
If TDML files in schema projects have these spurious characters that were formerly ignored, this change will break
those tests.
DAFFODIL-533