Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(gh-action): add Apache RAT & package license checker workflow w/ license header additions #1408

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

erisu
Copy link
Member

@erisu erisu commented Mar 12, 2024

Platforms affected

n/a

Motivation and Context

check license header and package dependency licenses during commit and pr submission

Description

create release audit workflow

Testing

n/a

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you confirmed that Xcode will still open all of these files in a generate app with no issues? (and yes, Xcode is probably going to aggressively delete these comments as soon as it loads the files 😑)

@erisu
Copy link
Member Author

erisu commented Mar 13, 2024

I tested the following and appears OK.

  • Creating a project (CLI)
  • Adding platform (CLI)
  • cordova build (CLI)
  • cordova run (CLI)
  • Opened Xcode
  • Build with Xcode
  • Run with Xcode
  • Clean Build Folders & Run with Xcode (Again)
  • Analyze with Xcode

@erisu erisu merged commit d316558 into apache:master Mar 13, 2024
10 checks passed
@erisu erisu deleted the ci/release-audit-workflow branch March 13, 2024 04:19
ishiguro-m-wing added a commit to dejiren/cordova-ios that referenced this pull request Mar 29, 2024
This reverts commit 1974dbb.

Revert "feat: add privacy-manifest config support (apache#1406)"

This reverts commit c97845a.

Revert "ci(gh-action): add Apache RAT & package license checker workflow w/ license header additions (apache#1408)"

This reverts commit d316558.

Revert "fix: use PROVISIONING_PROFILE_SPECIFIER for manual codesigning (apache#1405)"

This reverts commit af6335e.

Revert "feat: add PrivacyInfo.xcprivacy for CordovaLib & app template (apache#1383)"

This reverts commit b400b70.

Revert "fix: WASM MIME type error by specifying it in Info.plist template (apache#1374)"

This reverts commit 902df96.

Revert "chore: update package & package-lock (apache#1404)"

This reverts commit 2091208.

Revert "chore: bump 7.1.0-dev for next minor release (apache#1403)"

This reverts commit 766adcf.

Revert "chore(deps-dev): bump @babel/traverse from 7.21.4 to 7.23.2 (apache#1382)"

This reverts commit 92017bb.

Revert "chore: Update Slack signup link in SUPPORT_QUESTION.md (apache#1380)"

This reverts commit be4c884.

Revert "chore: bump version 7.0.2-dev"

This reverts commit a1f3ace.
ishiguro-m-wing pushed a commit to dejiren/cordova-ios that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants