fix: dirty fix SystemWebViewEngine by using history.back instead of g… #1321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
android
Motivation and Context
To pass the BackButtonMultipageTest.testViaHref() on Android 11 (SDK30) .
i.e. This PR fix the following error
in BackButtonMultipageTest.
Description
if we use the
window.location = new_url
in javascript and make a page transition,SDK29 or before => we can go back to previous page by
webView.goBack()
.SDK30 => we cannot go back to previous page by
webView.goBack()
.I don't know this is a bug or specification in SDK 30.
Anyway I used
history.back()
in javascript instead on SDK 30.Testing
Open the project
test/androidx
by AndroidStudio,and execute the BackButtonMultipageTest on Pixel 3 API 30 and API 29 in my local environment.
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)