Improve performance of encoding Uris #660
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no encoding occurred for a uri (which is quite often the case), there is no need to convert the StringBuilder to a String, just return the input String.
JMH
Before
Benchmark Mode Cnt Score Error Units
UriParserBenchmark.encode thrpt 25 5814265,085 ▒ 235637,894 ops/s
After
Benchmark Mode Cnt Score Error Units
UriParserBenchmark.encode thrpt 25 6764614,389 ▒ 213170,120 ops/s
16.3% improvement
I've also attached a screenshot of JMC showing that a lot of time of the
UriParser.encode
is spend in theStringBuilder.toString
Thanks for your contribution to Apache Commons! Your help is appreciated!
Before you push a pull request, review this list:
mvn
; that'smvn
on the command line by itself.