-
Notifications
You must be signed in to change notification settings - Fork 1.2k
custom AccessLogger #9733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
custom AccessLogger #9733
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9733 +/- ##
============================================
+ Coverage 16.17% 17.03% +0.85%
Complexity 13040 13040
============================================
Files 5645 5251 -394
Lines 494762 462358 -32404
Branches 59946 54220 -5726
============================================
- Hits 80050 78750 -1300
+ Misses 405884 374927 -30957
+ Partials 8828 8681 -147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLGTM!
e7e6fdb
to
03fa97c
Compare
@sureshanaparti could you review/test? |
@blueorangutan package |
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12408 |
@blueorangutan test |
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
[SF] Trillian test result (tid-12375)
|
[SF] Trillian test result (tid-12389)
|
Description
This PR...
Fixes: #9512
as it was only partially fixed in #9568. This PR addresses the access.log candor.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?