Skip to content

custom AccessLogger #9733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

custom AccessLogger #9733

wants to merge 6 commits into from

Conversation

DaanHoogland
Copy link
Contributor

Description

This PR...

Fixes: #9512
as it was only partially fixed in #9568. This PR addresses the access.log candor.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.03%. Comparing base (1c626c8) to head (03fa97c).
Report is 29 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9733      +/-   ##
============================================
+ Coverage     16.17%   17.03%   +0.85%     
  Complexity    13040    13040              
============================================
  Files          5645     5251     -394     
  Lines        494762   462358   -32404     
  Branches      59946    54220    -5726     
============================================
- Hits          80050    78750    -1300     
+ Misses       405884   374927   -30957     
+ Partials       8828     8681     -147     
Flag Coverage Δ
uitests ?
unittests 17.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland DaanHoogland marked this pull request as ready for review September 26, 2024 15:46
Copy link
Contributor

@FelipeM525 FelipeM525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM!

@DaanHoogland
Copy link
Contributor Author

@sureshanaparti could you review/test?

@DaanHoogland
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12408

@DaanHoogland
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-12375)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53233 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9733-t12375-kvm-ol8.zip
Smoke tests completed. 132 look OK, 2 have errors, 7 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_11_isolated_network_with_dynamic_routed_mode Error 2.26 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 2.39 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 2.39 test_ipv4_routing.py
test_12_start_vm_multiple_volumes_allocated Error 14.89 test_vm_life_cycle.py
all_test_vpc_redundant Skipped --- test_vpc_redundant.py
all_test_vpc_router_nics Skipped --- test_vpc_router_nics.py
all_test_vpc_vpn Skipped --- test_vpc_vpn.py
all_test_webhook_delivery Skipped --- test_webhook_delivery.py
all_test_webhook_lifecycle Skipped --- test_webhook_lifecycle.py
all_test_host_maintenance Skipped --- test_host_maintenance.py
all_test_hostha_kvm Skipped --- test_hostha_kvm.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-12389)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 55402 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9733-t12389-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_11_isolated_network_with_dynamic_routed_mode Error 2.35 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 2.48 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 2.48 test_ipv4_routing.py
test_12_start_vm_multiple_volumes_allocated Error 17.13 test_vm_life_cycle.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Password in plaintext in management and access logs
3 participants