-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add unit tests for getConfigResources in ModuleDefinitionSet and improve context readability #11042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@he1l0world , your change looks generally good to but one remarks: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11042 +/- ##
=========================================
Coverage 16.60% 16.60%
- Complexity 13925 13926 +1
=========================================
Files 5730 5730
Lines 508254 508254
Branches 61789 61789
=========================================
+ Hits 84387 84390 +3
+ Misses 414431 414430 -1
+ Partials 9436 9434 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Yes, it makes sense to me. I will update them |
c3a797d
to
390ac7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
@blueorangutan package |
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13820 |
Description
This PR adds unit test coverage for the
getConfigResources()
method in theModuleDefinitionSet
class to validate context resource logic. This ensures modules are loading the correct Spring context files, including contexts, inherited contexts, and overridden contexts.To improve readability and avoid confusion, some Spring context XML files were renamed to match their associated modules more intuitively.
Additionally, a small test refactor was made: the instantiation of
ModuleBasedContextFactory
was moved to the top of the test class as a shared field, since the factory is stateless and does not need to be recreated for each test caseTypes of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Not applicable
How Has This Been Tested?
Added
testConfigResources()
inModuleBasedContextFactoryTest.java
with assertions for expected Spring resource files.How did you try to break this feature and the system with this change?