[Vmware to KVM Migration] Preserve boot type and boot mode of instances to be migrated

[nvazquez]

Description

This PR ensures the converted/imported instances preserve the source VM boot mode and boot type.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

• Verify the source VM boot type and boot mode before importing:
  
• Import Vmware VM using KVM host for conversion having virt-v2v and ovftool installed
• Verify the imported VM contains the expected boot mode and boot type:

How did you try to break this feature and the system with this change?

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 16.15%. Comparing base (8f2735a) to head (6f68eca).

Files with missing lines	Patch %	Lines
.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java	77.77%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #10975   +/-   ##
=========================================
  Coverage     16.15%   16.15%           
- Complexity    13273    13275    +2     
=========================================
  Files          5657     5657           
  Lines        497898   497905    +7     
  Branches      60374    60374           
=========================================
+ Hits          80435    80442    +7     
+ Misses       408505   408504    -1     
- Partials       8958     8959    +1     

Flag	Coverage Δ
uitests	4.00% <ø> (ø)
unittests	17.00% <77.77%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13641

[nvazquez]

@blueorangutan test ol8 vmware-70u3

[blueorangutan]

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-13475)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 63409 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10975-t13475-vmware-70u3.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_deploy_more_vms_than_limit_allows	Error	150.11	test_deploy_vms_in_parallel.py
test_01_scale_vm	Error	1.52	test_scale_vm.py
test_02_scale_vm_negative_offering_disable_scaling	Error	1.40	test_scale_vm.py
test_03_scale_vm_negative_vm_disable_scaling	Error	1.39	test_scale_vm.py

[nvazquez]

@blueorangutan test ol8 vmware-70u3

[blueorangutan]

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-13485)

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[DaanHoogland]

logic looks good, but the code here needs some refactorring I think (new PR?) the method now is 153 lines and takes 21 parameters. Not sure about cyclic complexity and I really don’t want to know anymore by now.

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[sureshanaparti]

clgtm

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13792