Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UEFI support #83

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

vdombrovski
Copy link
Contributor

This adds a new boolean parameter to the cloudstack_instance resource, called "uefi". When set, the instance will boot in UEFI/Legacy mode.

@bragonznx
Copy link

@vdombrovski whaouuuuuu : awesome, thanks for this; it's very usefull.

@rohityadavcloud rohityadavcloud added this to the v0.5.0 milestone Feb 19, 2024
Copy link
Collaborator

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Created UEFI enabled host and registered a UEFI template

Deployed a vm from terraform succefully


resource "cloudstack_instance" "test-vm" {
  name             = var.instance_name
  service_offering = var.instance_service_offering
  network_id       = cloudstack_network.test-network.id
  template         = var.instance_template
  zone             = var.zone
  uefi = true
  expunge = true
  depends_on = [
   cloudstack_network.test-network
 ]
  
}


  # cloudstack_instance.test-vm will be created
  + resource "cloudstack_instance" "test-vm" {
      + display_name     = (known after apply)
      + expunge          = true
      + group            = (known after apply)
      + id               = (known after apply)
      + ip_address       = (known after apply)
      + name             = "hyd-demo-test"
      + network_id       = (known after apply)
      + project          = (known after apply)
      + root_disk_size   = (known after apply)
      + service_offering = "17dfb0b2-a153-4aae-aa79-41d830cf061b"
      + start_vm         = true
      + tags             = (known after apply)
      + template         = "ce2c6626-9dc9-4f3e-abea-a34bc6ee009f"
      + uefi             = true
      + zone             = "3e99a7d7-f23c-4650-8fc4-f5ebb9ea06c9"
    }



cloudstack_instance.test-vm: Still creating... [30s elapsed]
cloudstack_instance.test-vm: Still creating... [40s elapsed]
cloudstack_instance.test-vm: Creation complete after 49s [id=eccbfa4b-f932-4489-af08-78aee336aabd]

Screenshot 2024-03-06 at 12 45 58 PM

@rohityadavcloud rohityadavcloud merged commit f08f5a5 into apache:main Mar 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants