Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding configuration resource #57

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adding configuration resource #57

wants to merge 3 commits into from

Conversation

poddm
Copy link
Contributor

@poddm poddm commented Apr 19, 2023 •
edited
Loading

Adding cloudstack configuration resource.

  # cloudstack_configuration.example will be created
  + resource "cloudstack_configuration" "example" {
      + category    = (known after apply)
      + description = (known after apply)
      + id          = (known after apply)
      + is_dynamic  = (known after apply)
      + name        = "host"
      + scope       = (known after apply)
      + value       = "example"
    }

This requires the latest client. See -
https://github.com/apache/cloudstack-go/releases/tag/v2.14.0
apache/cloudstack-go#47

@poddm poddm marked this pull request as ready for review June 21, 2023 19:58
@rohityadavcloud rohityadavcloud added this to the v0.5.0 milestone Aug 4, 2023
@rohityadavcloud
Copy link
Member

@poddm thanks for the PR, do we need to use the latest go-sdk release (https://github.com/apache/cloudstack-go/releases) ? LGTM havn't tested it though. (closed/reopen PR to rekick Github actions build job)

rohityadavcloud
rohityadavcloud approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM didn't test it though

@poddm poddm force-pushed the resource_configuration branch 2 times, most recently from e6e7db2 to a0c7bb6 Compare October 31, 2023 20:41
vishesh92
vishesh92 reviewed Mar 6, 2024
View reviewed changes
cloudstack/provider.go Outdated
"cloudstack_disk": resourceCloudStackDisk(),
"cloudstack_egress_firewall": resourceCloudStackEgressFirewall(),
"cloudstack_firewall": resourceCloudStackFirewall(),
"cloudstack_instance": resourceCloudStackInstance(),
"cloudstack_ipaddress": resourceCloudStackIPAddress(),
"cloudstack_kubernetes_cluster": resourceCloudStackKubernetesCluster(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it required to remove this?

vishesh92
vishesh92 reviewed Mar 6, 2024
View reviewed changes
cloudstack/resource_cloudstack_instance.go Outdated
@@ -570,7 +570,7 @@ func resourceCloudStackInstanceUpdate(d *schema.ResourceData, meta interface{})
if d.HasChange("keypair") {
log.Printf("[DEBUG] SSH keypair changed for %s, starting update", name)

p := cs.SSH.NewResetSSHKeyForVirtualMachineParams(d.Id(), d.Get("keypair").(string))
p := cs.SSH.NewResetSSHKeyForVirtualMachineParams(d.Id())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should set the keypair param here as well.

vishesh92
vishesh92 reviewed Mar 6, 2024
View reviewed changes
cloudstack/resource_cloudstack_private_gateway.go Outdated
@@ -100,7 +100,6 @@ func resourceCloudStackPrivateGatewayCreate(d *schema.ResourceData, meta interfa
d.Get("gateway").(string),
ipaddress,
d.Get("netmask").(string),
d.Get("vlan").(string),
d.Get("vpc_id").(string),
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If vlan is available, update the params.

vishesh92
vishesh92 reviewed Mar 6, 2024
View reviewed changes
cloudstack/resource_cloudstack_configuration.go
d.Set("name", v.Name)
d.Set("value", v.Value)
d.Set("scope", v.Scope)
found = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
found = true
found = true
break

@vishesh92 vishesh92 modified the milestones: v0.5.0, v0.6.0 Mar 7, 2024
@poddm
Copy link
Contributor Author

poddm commented Mar 26, 2024

@vishesh92, These were cascading changes from updating to the latest client sdk apache/cloudstack-go#47. They were not meant to be committed.

I'll rebase when #101 is merged.

@poddm
Copy link
Contributor Author

poddm commented Apr 26, 2024 •
edited
Loading

Update - I'd still like to get these merged once the cloudstack SDK is updated.

Related SDK changes

@rohityadavcloud
Copy link
Member

Closing/re-opening to kick tests.

@rohityadavcloud
Copy link
Member

@poddm there are conflicts on the PR - can you please resolve?

@vishesh92
Copy link
Member

@poddm Acceptance tests are failing. Can you check and fix those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishesh92 vishesh92 vishesh92 left review comments

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

@harikrishna-patnala harikrishna-patnala Awaiting requested review from harikrishna-patnala

@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594

Assignees

@vishesh92 vishesh92

Labels
None yet
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@poddm @rohityadavcloud @vishesh92