Remove a fixme of plpgsql tests #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It acts as expected, remove the comment fixme.
… specified (#16919) Before this commit, GPDB won't push OFFSET/LIMIT in the remote servers for MPP FDW when both offset and limit clause are specified. Because it's unsafe if we don't adjust Remote SQL. In this commit, we consider MPP FDW OFFSET/LIMIT pushdown when both OFFSET and LIMIT clause are specified. We will adjust Remote SQL when mpp_execute = 'all segments' for query including OFFSET/LIMIT clause.
my-ship-it
approved these changes
Jan 24, 2025
`pg_upgrade_greenplum.c` no longer exists and has been renamed to `controldata_gp.c`.
Backport from upstream postgres/postgres@7201cd1 Previously, we encoded both NULL and the first byte at the base address as 0. That confusion led to the assertion in commit e07d4ddc, which failed when min_dynamic_shared_memory was used. Give them distinct encodings, by switching to 1-based offsets for non-NULL pointers. Also improve macro hygiene in passing (missing/misplaced parentheses), and remove open-coded access to the raw offset value from freepage.c/h. Although e07d4ddc was back-patched to 10, the only code that actually makes use of relptr at the base address arrived in 84b1c63, so no need to back-patch further than 14 for now. Reported-by: Justin Pryzby <[email protected]> Reviewed-by: Robert Haas <[email protected]> Discussion: https://postgr.es/m/20220519193839.GT19626%40telsasoft.com (cherry picked from commit 7201cd18627afc64850537806da7f22150d1a83b) Co-authored-by: Thomas Munro <[email protected]>
…yntax (#17252) Add a test case that external table location URI contains special character '|' for CREATE FOREIGN TABLE syntax.
Fix pipeline diff caused by different length of `--------` in SELECT result.
This is exposed by Orca's support for query parameters. In retail build it would still run fine, but it's better to make this explicit.
According to C99 7.13.2.1[^1], > All accessible objects have values, and all other components of the abstract machine have state, as of the time the longjmp function was called, except that the values of objects of automatic storage duration that are local to the function containing the invocation of the corresponding setjmp macro that do not have volatile-qualified type and have been changed between the setjmp invocation and longjmp call are indeterminate. The object `toplevelOidCache` is changed in line 657 (in the PG_TRY() block) and read in line 719 (in the PG_CATCH() block). We should qualify it with `volatile`. [^1]: https://www.open-std.org/jtc1/sc22/wg14/www/docs/n1256.pdf
Backported from upstream commit: 64da07c41a8c0a680460cdafc79093736332b6cf with one important difference: we didn't absorb the log_autovacuum_min_duration change. This is because in GPDB, autovacuum driven autoanalyze can take longer due to the size of GPDB tables (and also analyze is dispatched from the QD). So, we decide to be conservative about that change. Original commit message follows: The idea here is that when a performance problem is known to have occurred at a certain point in time, it's a good thing if there is some information available from the logs to help figure out what might have happened around that time. This change attracted an above-average amount of dissent, because it means that a server with default settings will produce some amount of log output even if nothing has gone wrong. However, by my count, the mailing list discussion had about twice as many people in favor of the change as opposed. The reasons for believing that the extra log output is not an issue in practice are: (1) the rate at which messages can be generated by this setting is bounded to one every few minutes on a properly-configured system and (2) production systems tend to have a lot more junk in the log from that due to failed connection attempts, ERROR messages generated by application activity, and the like. Bharath Rupireddy, reviewed by Fujii Masao and by me. Many other people commented on the thread, but as far as I can see that was discussion of the merits of the change rather than review of the patch. Discussion: https://postgr.es/m/CALj2ACX-rW_OeDcp4gqrFUAkf1f50Fnh138dmkd0JkvCNQRKGA@mail.gmail.com Reviewed-by: Marbin Tan <[email protected]>
Even though we claim that triggers are not supported in Greenplum, users were still allowed to create them in GP6. In GP7, we've disabled creating triggers, as such, restoring from GP6 that has triggers will cause issues. Add a new GUC `gp_enable_statement_trigger` to let `pg_restore` and users by pass this issue and create the trigger anyway when the GUC `gp_enable_statement_trigger` is on. The default value of `gp_enable_statement_trigger` is off. Creating Triggers in GP7 were disabled in commit https://github.com/greenplum-db/gpdb/commit/2325cffa86fa663567693cf54d5a98e7d5ed665f.
reshke
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions