[CELEBORN-1853] Remove idle executors when DRA enable and using Celeborn #3088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what's DRA can you please give detail name? |
spark.dynamicAllocation.enabled |
pan3793
reviewed
Feb 7, 2025
| // from a Standalone cluster, where the shuffle service lives in the Worker.) | ||
| - val fileLost = !sc.shuffleDriverComponents.supportsReliableStorage() && | ||
| + val fileLost = !Utils.isCelebornEnabled(sc.getConf) && | ||
| + !sc.shuffleDriverComponents.supportsReliableStorage() && |
There was a problem hiding this comment.
why !sc.shuffleDriverComponents.supportsReliableStorage() is not sufficent here?
There was a problem hiding this comment.
Per the doc:
# Support Spark Dynamic Resource Allocation
# Required Spark version >= 3.5.0
spark.shuffle.sort.io.plugin.class org.apache.spark.shuffle.celeborn.CelebornShuffleDataIO
|
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove idle executors when spark.dynamicAllocation.enabled is true and using Celeborn
Why are the changes needed?
When using Celeborn as remote shuffle service, the idle executors can be removed although
hasActiveShuffleis true in DRA condition.Does this PR introduce any user-facing change?
Spark patch change.
How was this patch tested?
Cluster testing.