Skip to content

Commit

Permalink
[CELEBORN-805][FOLLOWUP] Remove unnecessary TODO
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?

As title

### Why are the changes needed?

cleanup the unnecessary TODO which introduced in #1727

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Review

Closes #1728 from cfmcgrady/shutdown.

Authored-by: Fu Chen <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit 16d9c65)
Signed-off-by: Cheng Pan <[email protected]>
  • Loading branch information
cfmcgrady authored and pan3793 committed Jul 18, 2023
1 parent affc8f1 commit 1aecf34
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,6 @@ private[celeborn] class Worker(
masterClient.close()
replicateServer.shutdown(graceful)
fetchServer.shutdown(graceful)
// TODO: `pushServer` never be closed before this PR.
pushServer.shutdown(graceful)

super.shutdown(graceful)
Expand Down

0 comments on commit 1aecf34

Please sign in to comment.