Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-20888 - Remove Kotlin DSL #15481

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

apupier
Copy link
Contributor

@apupier apupier commented Sep 9, 2024

Kotlin DSL was deprecated in Camel 4.7
It was not used a lot and it takes a fair part of the build time.

Description

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

Copy link
Contributor

github-actions bot commented Sep 9, 2024

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@apupier
Copy link
Contributor Author

apupier commented Sep 9, 2024

better to merge these other Pull Requests first to avoid breaking some other projects:

finally not needed, will be done later when projects will adopt Camel 4.9:

EDIT: only Camel Quarkus is required as Camel K is based on older version (only deprecation in Camel K would be nice)
@jamesnetherton will take care of the Quarkus side https://github.com/jamesnetherton

EDIT2: in fact, Camel Quarkus is still on Camel 4.7, James will take care of the upgrade when Camel Quarkus will move to Camel 4.9

Copy link
Contributor

@orpiske orpiske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davsclaus
Copy link
Contributor

Need to regen as main branch has updated since

@davsclaus
Copy link
Contributor

@apupier the upgrade guide doc has a conflict

Kotlin DSL was deprecated in Camel 4.7
It was not used a lot and it takes a fair part of the build time.

Signed-off-by: Aurélien Pupier <[email protected]>
@apupier
Copy link
Contributor Author

apupier commented Sep 10, 2024

while checking camel-website if requring new changes, I found https://camel.apache.org/blog/2024/02/camel44-whatsnew/#kotlin-api

Kotlin API is not the replacement of Kotlin DSL (it is a separate module for now). While it is experimental there may be breaking changes in upcoming releases.

This PR is in fact removing all kotlin related things

@davsclaus
Copy link
Contributor

while checking camel-website if requring new changes, I found https://camel.apache.org/blog/2024/02/camel44-whatsnew/#kotlin-api

Kotlin API is not the replacement of Kotlin DSL (it is a separate module for now). While it is experimental there may be breaking changes in upcoming releases.

This PR is in fact removing all kotlin related things

That is fine - all of this was experimental and manually hand code to be up to date. And there is little uptake of this.
This kind of stuff is better first done outside ASF to build up and gain momentum before dumped to core project and left for us to maintain.

@apupier apupier marked this pull request as ready for review September 10, 2024 12:02
@apupier apupier merged commit 8af014c into apache:main Sep 10, 2024
4 checks passed
@apupier apupier deleted the 20888-removeKotlinDSL-2 branch September 10, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants