Variables - test coverage #5654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Jan 17, 2024
JiriOndrusek
changed the title
JiriOndrusek
force-pushed
the
variable-support
branch
from
855751d
to
f379e59
Compare
aldettinger
reviewed
Jan 17, 2024
...ndation/variables/src/main/java/org/apache/camel/quarkus/variables/it/VariablesResource.java
Outdated
Show resolved
Hide resolved
aldettinger
reviewed
Jan 17, 2024
...ndation/variables/src/main/java/org/apache/camel/quarkus/variables/it/VariablesResource.java
Outdated
Show resolved
Hide resolved
aldettinger
reviewed
Jan 17, 2024
...ndation/variables/src/main/java/org/apache/camel/quarkus/variables/it/VariablesResource.java
Outdated
Show resolved
Hide resolved
aldettinger
reviewed
Jan 17, 2024
...ables/src/test/java/org/apache/camel/quarkus/variables/it/CustomRepositoryVariablesTest.java
Outdated
Show resolved
Hide resolved
aldettinger
reviewed
Jan 17, 2024
...ables/src/test/java/org/apache/camel/quarkus/variables/it/CustomRepositoryVariablesTest.java
Show resolved
Hide resolved
aldettinger
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Looks pretty decent @JiriOndrusek
Concerning mock.reset(), I would vote to find another way if possible. If too difficult, maybe we just add a comment to have context in case the test is proven to be flaky on ci one day.
JiriOndrusek
force-pushed
the
variable-support
branch
2 times, most recently
from
8b2cd18
to
d4756fe
Compare
Thank you for the review! |
jamesnetherton
approved these changes
Jan 18, 2024
JiriOndrusek
force-pushed
the
camel-main
branch
from
f31c6c1
to
06f9e8d
Compare
JiriOndrusek
force-pushed
the
variable-support
branch
from
d4756fe
to
56bc119
Compare
JiriOndrusek
added a commit
that referenced
this pull request
Jan 23, 2024
JiriOndrusek
added a commit
that referenced
this pull request
Jan 25, 2024
JiriOndrusek
added a commit
that referenced
this pull request
Jan 26, 2024
JiriOndrusek
added a commit
that referenced
this pull request
Jan 29, 2024
JiriOndrusek
added a commit
that referenced
this pull request
Jan 31, 2024
JiriOndrusek
added a commit
that referenced
this pull request
Feb 5, 2024
JiriOndrusek
added a commit
that referenced
this pull request
Feb 12, 2024
JiriOndrusek
added a commit
to JiriOndrusek/camel-quarkus
that referenced
this pull request
Feb 13, 2024
JiriOndrusek
added a commit
to JiriOndrusek/camel-quarkus
that referenced
this pull request
Feb 13, 2024
jamesnetherton
pushed a commit
to JiriOndrusek/camel-quarkus
that referenced
this pull request
Feb 17, 2024
jamesnetherton
pushed a commit
that referenced
this pull request
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #5620
(the other part of the solution is the example - apache/camel-quarkus-examples#194)
This PR adds basic variables coverage into
integration-test-groups/foundation.One test (
customVariablerepository) is not executed in the native move, because it is not possible to remove a CDI bean for one test. IMO the tested functionality uses functions which were already part of the Camel before, therefore there is no reason to test this in native.