Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add saga example #231

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Add saga example #231

merged 2 commits into from
Jun 17, 2024

Conversation

zhfeng
Copy link
Contributor

@zhfeng zhfeng commented Jun 14, 2024

Fix apache/camel-quarkus#5668

Note that the main branch points at the latest stable Camel Quarkus release.
Pull requests should be generally send against the camel-quarkus-main branch pointing at the current Camel Quarkus SNAPSHOT.

@zhfeng zhfeng force-pushed the saga-example branch 2 times, most recently from f3e4b33 to df02394 Compare June 14, 2024 07:48
@jamesnetherton
Copy link
Contributor

I think you'll need to tweak the script that generates the test categories:

https://github.com/apache/camel-quarkus-examples/blob/main/.github/generate-test-groups.groovy

It'll recursively find all pom.xml files. I think we only want the top level ones from each project.

Copy link
Contributor

@jamesnetherton jamesnetherton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

I guess there are no tests because it's tricky to do since there are 3 separate apps?

Would be good to create an issue to follow up and investigate adding tests for the future.

@zhfeng
Copy link
Contributor Author

zhfeng commented Jun 14, 2024

Yeah, there are 3 apps and also depends on artemis and narayana-lra-coordinator. I will take a look to see if it is possible to add a integration test.

@zhfeng
Copy link
Contributor Author

zhfeng commented Jun 17, 2024

OK, I create a following issue apache/camel-quarkus#6195

@zhfeng zhfeng merged commit 1d386c3 into apache:camel-quarkus-main Jun 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants