-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate jpa-idempotent-repository example from deprecated derby container image to MariaDB #195
Migrate jpa-idempotent-repository example from deprecated derby container image to MariaDB #195
Conversation
@jamesnetherton Many thanks for stepping in. Could you please share how/where the derby container image is identified as deprecated ? Also trying to rehearse locally,
Any idea why the kubernetes-client is already involved at this step ? |
See here az82/docker-derby@ad7612b.
Yes, It's because I introduced |
1a8e19c
to
6537e03
Compare
I reworked how the secret config is done. The issue should be fixed in the latest commit. |
There was a situation where the cleanup was not done fully: Executing And I end up with 2 jpa-idempotent-repository pods:
Actually, it's just the flyway one. I was mislead by the expectation from the doc where there are only 2 pods expected. |
…iner image to MariaDB
6537e03
to
aa76218
Compare
Latest commit tweaks the README docs to mention the additional pod and modifies the cleanup step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @jamesnetherton 👍 Indeed looking at container image project source could help to spot deprecation of images.
Also, removing dual database setup is also more consistent. This is less maintenance cost for just a few seconds more of testing delay.
At the end of the day, the example experience remains relevant with mariadb too.
Kind of an extension to apache/camel-quarkus#5634. We should avoid using the deprecated Derby container image if possible. So I switched to MariaDB, as it supports a nice range of different architectures.
I also dropped the dual database setup between dev & prod mode (E.g no more H2). IMO it simplifies things.