Skip to content

Commit

Permalink
Replace quarkus-test-artemis with dev services container
Browse files Browse the repository at this point in the history
  • Loading branch information
jamesnetherton committed Sep 2, 2024
1 parent 244d6c9 commit bc53ae5
Show file tree
Hide file tree
Showing 9 changed files with 7 additions and 107 deletions.
5 changes: 0 additions & 5 deletions jms-jpa/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -136,11 +136,6 @@
<artifactId>quarkus-test-h2</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.quarkiverse.artemis</groupId>
<artifactId>quarkus-test-artemis</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.rest-assured</groupId>
<artifactId>rest-assured</artifactId>
Expand Down
1 change: 0 additions & 1 deletion jms-jpa/src/main/resources/application.properties
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ camel.rest.context-path=/api

# Quarkus Artemis
quarkus.artemis.enabled=true
%test.quarkus.artemis.devservices.enabled=false
#%prod.quarkus.artemis.url=tcp://localhost:61616
#%prod.quarkus.artemis.username=admin
#%prod.quarkus.artemis.password=admin
Expand Down
2 changes: 0 additions & 2 deletions jms-jpa/src/test/java/org/acme/JtaTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
import java.util.UUID;
import java.util.concurrent.TimeUnit;

import io.quarkus.artemis.test.ArtemisTestResource;
import io.quarkus.test.common.WithTestResource;
import io.quarkus.test.h2.H2DatabaseTestResource;
import io.quarkus.test.junit.QuarkusTest;
Expand All @@ -31,7 +30,6 @@

@QuarkusTest
@WithTestResource(H2DatabaseTestResource.class)
@WithTestResource(ArtemisTestResource.class)
public class JtaTest {
@Test
public void testXA() {
Expand Down
44 changes: 0 additions & 44 deletions jms-jpa/src/test/resources/broker.xml

This file was deleted.

6 changes: 0 additions & 6 deletions message-bridge/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -124,12 +124,6 @@
<artifactId>camel-quarkus-junit5</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.quarkiverse.artemis</groupId>
<artifactId>quarkus-test-artemis</artifactId>
<version>${quarkus-artemis-jms.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>testcontainers</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ JmsComponent ibmmq(@Identifier("ibmConnectionFactory") ConnectionFactory cf, Jta
* @return a new JmsComponent instance
*/
@Identifier("amq")
JmsComponent amq(@Identifier("amqConnectionFactory") ConnectionFactory cf, JtaTransactionManager tm) {
JmsComponent amq(ConnectionFactory cf, JtaTransactionManager tm) {
JmsComponent amq = new JmsComponent();
amq.setConnectionFactory(cf);
amq.setTransactionManager(tm);
Expand Down
11 changes: 6 additions & 5 deletions message-bridge/src/main/resources/application.properties
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,12 @@ ibm.mq.user=app
ibm.mq.password=passw0rd
ibm.mq.queue=DEV.QUEUE.1

quarkus.artemis.amqConnectionFactory.url=tcp://localhost:61616
%kubernetes.quarkus.artemis.amqConnectionFactory.url=tcp://${ACTIVEMQ_SERVICE_HOST}:61616
%openshift.quarkus.artemis.amqConnectionFactory.url=tcp://activemq-artemis-broker:61616
quarkus.artemis.amqConnectionFactory.username=admin
quarkus.artemis.amqConnectionFactory.password=admin
quarkus.artemis.devservices.enabled=true
%prod.quarkus.artemis.url=tcp://localhost:61616
%prod.quarkus.artemis.username=admin
%prod.quarkus.artemis.password=admin
%kubernetes.quarkus.artemis.url=tcp://${ACTIVEMQ_SERVICE_HOST}:61616
%openshift.quarkus.artemis.url=tcp://activemq-artemis-broker:61616
amq.queue=in

quarkus.pooled-jms.transaction=xa
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
import java.nio.file.Paths;
import java.util.concurrent.TimeUnit;

import io.quarkus.artemis.test.ArtemisTestResource;
import io.quarkus.test.common.WithTestResource;
import io.quarkus.test.junit.QuarkusIntegrationTest;
import io.restassured.RestAssured;
Expand All @@ -37,7 +36,6 @@
import static org.assertj.core.api.Assertions.assertThat;

@QuarkusIntegrationTest
@WithTestResource(ArtemisTestResource.class)
@WithTestResource(IBMMQTestResource.class)
// The crash test will kill the app, so it must be executed last as there is no way to restart the application
@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
Expand Down
41 changes: 0 additions & 41 deletions message-bridge/src/test/resources/broker.xml

This file was deleted.

0 comments on commit bc53ae5

Please sign in to comment.