Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove PROBLEMATIC tests flag and reporting #5683

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/actions/e2e-builder/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,12 +103,6 @@ runs:
image-registry-insecure: ${{steps.config-cluster.outputs.cluster-image-registry-insecure }}
image-version: ${{ steps.build-kamel.outputs.build-binary-local-image-version }}

- id: report-problematic
name: List Tests Marked As Problematic
uses: ./.github/actions/kamel-report-problematic
with:
test-suite: global/builder

- id: run-it
name: Run IT
shell: bash
Expand Down
6 changes: 0 additions & 6 deletions .github/actions/e2e-common/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,6 @@ runs:
image-registry-insecure: ${{steps.config-cluster.outputs.cluster-image-registry-insecure }}
image-version: ${{ steps.build-kamel.outputs.build-binary-local-image-version }}

- id: report-problematic
name: List Tests Marked As Problematic
uses: ./.github/actions/kamel-report-problematic
with:
test-suite: global/common

- id: run-it
name: Run IT
shell: bash
Expand Down
6 changes: 0 additions & 6 deletions .github/actions/e2e-install-olm/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,6 @@ runs:
catalog-source-name: ${{ steps.config-cluster.outputs.cluster-catalog-source-name }}
catalog-source-namespace: ${{ steps.config-cluster.outputs.cluster-catalog-source-namespace }}

- id: report-problematic
name: List Tests Marked As Problematic
uses: ./.github/actions/kamel-report-problematic
with:
test-suite: namespace/upgrade

- name: Run IT
shell: bash
run: |
Expand Down
6 changes: 0 additions & 6 deletions .github/actions/e2e-install-upgrade/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,6 @@ runs:
catalog-source-name: ${{ steps.config-cluster.outputs.cluster-catalog-source-name }}
catalog-source-namespace: ${{ steps.config-cluster.outputs.cluster-catalog-source-namespace }}

- id: report-problematic
name: List Tests Marked As Problematic
uses: ./.github/actions/kamel-report-problematic
with:
test-suite: namespace/upgrade

- name: Run IT
shell: bash
run: |
Expand Down
6 changes: 0 additions & 6 deletions .github/actions/e2e-install/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,6 @@ runs:
image-registry-insecure: ${{steps.config-cluster.outputs.cluster-image-registry-insecure }}
image-version: ${{ steps.build-kamel.outputs.build-binary-local-image-version }}

- id: report-problematic
name: List Tests Marked As Problematic
uses: ./.github/actions/kamel-report-problematic
with:
test-suite: namespace/install

- id: run-it
name: Run IT
shell: bash
Expand Down
6 changes: 0 additions & 6 deletions .github/actions/e2e-knative-yaks/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,6 @@ runs:
image-name: "docker.io/citrusframework/yaks"
version: 0.19.1

- id: report-problematic
name: List Tests Marked As Problematic
uses: ./.github/actions/kamel-report-problematic
with:
test-suite: yaks/common

- id: run-it
name: Run IT
shell: bash
Expand Down
6 changes: 0 additions & 6 deletions .github/actions/e2e-knative/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,12 +103,6 @@ runs:
image-registry-insecure: ${{steps.config-cluster.outputs.cluster-image-registry-insecure }}
image-version: ${{ steps.build-kamel.outputs.build-binary-local-image-version }}

- id: report-problematic
name: List Tests Marked As Problematic
uses: ./.github/actions/kamel-report-problematic
with:
test-suite: global/knative

- id: run-it
name: Run IT
shell: bash
Expand Down
6 changes: 0 additions & 6 deletions .github/actions/e2e-native/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,6 @@ runs:
image-registry-insecure: ${{steps.config-cluster.outputs.cluster-image-registry-insecure }}
image-version: ${{ steps.build-kamel.outputs.build-binary-local-image-version }}

- id: report-problematic
name: List Tests Marked As Problematic
uses: ./.github/actions/kamel-report-problematic
with:
test-suite: namespace/native

- id: run-it
name: Run IT
shell: bash
Expand Down
6 changes: 0 additions & 6 deletions .github/actions/e2e-telemetry/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,12 +105,6 @@ runs:
otlp-collector-image-name: otel/opentelemetry-collector
otlp-collector-image-version: 0.102.0

- id: report-problematic
name: List Tests Marked As Problematic
uses: ./.github/actions/kamel-report-problematic
with:
test-suite: global/common

- id: run-it
name: Run IT
shell: bash
Expand Down
35 changes: 0 additions & 35 deletions .github/actions/kamel-report-problematic/action.yml

This file was deleted.

89 changes: 0 additions & 89 deletions .github/actions/kamel-report-problematic/report-problematic.sh

This file was deleted.

5 changes: 0 additions & 5 deletions .github/workflows/builder.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,6 @@ on:
pre-built-kamel-image:
description: 'Kamel image url for skipping building of kamel stages. Used for debugging'
required: false
skip-problematic:
description: 'Whether tests marked as problematic should be skipped - false by default (sets CAMEL_K_TEST_SKIP_PROBLEMATIC)'
required: false
default: false
test-filters:
description: |
Filter the tests in this test suite by assigning the test pattern to TEST_KNATIVE_RUN,
Expand Down Expand Up @@ -90,7 +86,6 @@ jobs:
run: |
./.github/workflows/manual-exec-process-inputs.sh \
-i "${{ github.event.inputs.pre-built-kamel-image }}" \
-p "${{ github.event.inputs.skip-problematic }}" \
-q "${{ github.event.inputs.log-level }}" \
-t "${{ github.event.inputs.test-filters }}"

Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/common.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,6 @@ on:
pre-built-kamel-image:
description: 'Kamel image url for skipping building of kamel stages. Used for debugging'
required: false
skip-problematic:
description: 'Whether tests marked as problematic should be skipped - false by default (sets CAMEL_K_TEST_SKIP_PROBLEMATIC)'
required: false
default: false
test-filters:
description: |
List of comma-separated key/value pairs to filter the tests in this test suite:
Expand Down Expand Up @@ -91,7 +87,6 @@ jobs:
run: |
./.github/workflows/manual-exec-process-inputs.sh \
-i "${{ github.event.inputs.pre-built-kamel-image }}" \
-p "${{ github.event.inputs.skip-problematic }}" \
-q "${{ github.event.inputs.log-level }}" \
-t "${{ github.event.inputs.test-filters }}"
- name: Common tests
Expand All @@ -114,7 +109,6 @@ jobs:
run: |
./.github/workflows/manual-exec-process-inputs.sh \
-i "${{ github.event.inputs.pre-built-kamel-image }}" \
-p "${{ github.event.inputs.skip-problematic }}" \
-q "${{ github.event.inputs.log-level }}" \
-t "${{ github.event.inputs.test-filters }}"
- name: Common advanced tests
Expand Down
7 changes: 0 additions & 7 deletions .github/workflows/install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,6 @@ on:
pre-built-kamel-image:
description: 'Kamel image url for skipping building of kamel stages. Used for debugging'
required: false
skip-problematic:
description: 'Whether tests marked as problematic should be skipped - false by default (sets CAMEL_K_TEST_SKIP_PROBLEMATIC)'
required: false
default: false
test-filters:
description: |
List of comma-separated key/value pairs to filter the tests in this test suite:
Expand Down Expand Up @@ -95,7 +91,6 @@ jobs:
run: |
./.github/workflows/manual-exec-process-inputs.sh \
-i "${{ github.event.inputs.pre-built-kamel-image }}" \
-p "${{ github.event.inputs.skip-problematic }}" \
-q "${{ github.event.inputs.log-level }}" \
-t "${{ github.event.inputs.test-filters }}"

Expand All @@ -119,7 +114,6 @@ jobs:
run: |
./.github/workflows/manual-exec-process-inputs.sh \
-i "${{ github.event.inputs.pre-built-kamel-image }}" \
-p "${{ github.event.inputs.skip-problematic }}" \
-q "${{ github.event.inputs.log-level }}" \
-t "${{ github.event.inputs.test-filters }}"

Expand All @@ -143,7 +137,6 @@ jobs:
run: |
./.github/workflows/manual-exec-process-inputs.sh \
-i "${{ github.event.inputs.pre-built-kamel-image }}" \
-p "${{ github.event.inputs.skip-problematic }}" \
-q "${{ github.event.inputs.log-level }}" \
-t "${{ github.event.inputs.test-filters }}"

Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/knative.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,6 @@ on:
pre-built-kamel-image:
description: 'Kamel image url for skipping building of kamel stages. Used for debugging'
required: false
skip-problematic:
description: 'Whether tests marked as problematic should be skipped - false by default (sets CAMEL_K_TEST_SKIP_PROBLEMATIC)'
required: false
default: false
test-filters:
description: |
Filter the tests in this test suite by assigning the test pattern to TEST_KNATIVE_RUN,
Expand All @@ -84,7 +80,6 @@ jobs:
run: |
./.github/workflows/manual-exec-process-inputs.sh \
-i "${{ github.event.inputs.pre-built-kamel-image }}" \
-p "${{ github.event.inputs.skip-problematic }}" \
-q "${{ github.event.inputs.log-level }}" \
-t "${{ github.event.inputs.test-filters }}"

Expand Down
10 changes: 0 additions & 10 deletions .github/workflows/manual-exec-process-inputs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ while getopts ":i:p:q:t:" opt; do
i)
PRE_BUILT_IMAGE=${OPTARG}
;;
p)
SKIP_PROBLEMATIC=${OPTARG}
;;
q)
LOG_LEVEL=${OPTARG}
;;
Expand All @@ -61,13 +58,6 @@ if [ -n "${PRE_BUILT_IMAGE}" ]; then
echo "DEBUG_USE_EXISTING_IMAGE=${PRE_BUILT_IMAGE}" >> $GITHUB_ENV
fi

#
# Avoid problematic tests only if parameter set to true
#
if [ "${SKIP_PROBLEMATIC}" == "true" ]; then
echo "CAMEL_K_TEST_SKIP_PROBLEMATIC=true" >> $GITHUB_ENV
fi

#
# Adds -run args to filter tests in test suites
#
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/native.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,6 @@ on:
pre-built-kamel-image:
description: 'Kamel image url for skipping building of kamel stages. Used for debugging'
required: false
skip-problematic:
description: 'Whether tests marked as problematic should be skipped - false by default (sets CAMEL_K_TEST_SKIP_PROBLEMATIC)'
required: false
default: false
test-filters:
description: |
Filter the tests in this test suite by assigning the test pattern to TEST_NATIVE_RUN,
Expand All @@ -89,7 +85,6 @@ jobs:
run: |
./.github/workflows/manual-exec-process-inputs.sh \
-i "${{ github.event.inputs.pre-built-kamel-image }}" \
-p "${{ github.event.inputs.skip-problematic }}" \
-q "${{ github.event.inputs.log-level }}" \
-t "${{ github.event.inputs.test-filters }}"
- name: Quarkus Native test
Expand Down
Loading
Loading