Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSon Logging Extension for Maven 3 and Maven 4 #5500

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gnodet
Copy link

@gnodet gnodet commented May 13, 2024

No description provided.

@lburgazzoli
Copy link
Contributor

@claudio4j @squakez this Pr aims to make the process to enable maven jaon logging easier so instead of having to do some maven calsspath enrichment, we only need add the extension to the pom

would be nice if you'd have a look

Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't worked on it lately, but I guess this change has to be coupled with the way how we create the operator container in https://github.com/apache/camel-k/blob/main/build/Dockerfile. @claudio4j may provide more inputs on this part as he has been working on it lately.

@claudio4j
Copy link
Contributor

  • the maven 3 module uses an older logstash and slf4j version, I suppose this is because of the slf4j 1.x version already in maven 3
  • how this is this supposed to work to actually build an integration in camel-k-operator ?
  • can we exclude maven4 module as maven4 is still in alpha and there is no plan yet to use maven4 in camel-k. This can help code maintenance.

@lburgazzoli
Copy link
Contributor

how this is this supposed to work to actually build an integration in camel-k-operator

The operator should either configure the extension on the generated project or define it in the global maven' settings.xml

@claudio4j claudio4j marked this pull request as draft July 2, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants