-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor kustomize experiment #4839
Conversation
3464624
to
7e8261c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. A few comments you may want to consider, but, in general I think it's the correct path.
kubectl kustomize <path/to/localrepo/install/overlays/openshift | kubectl create -f - | ||
``` | ||
|
||
To ensure the `IntegrationPlatform` custom resource is created add in the `kustomization.yaml`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it the only option we need to declare? in such case, I think it would be best to make a default value ootb.
* Set the build strategy | ||
* Set the build order strategy | ||
* Set how long the build process can last | ||
* Set how long the catalogtool image build can last |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's deprecated, so, we can remove it.
|
||
First create a new kustomization from the wanted version (kubernetes or openshift) in the repository: | ||
```sh | ||
kustomize create --resources https://github.com/apache/camel-k.git/install/overlays/kubernetes\?ref\=exp/kustomize_structure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, this one should be a separate chapter for user customization. We should not require anything but kubectl
for a immediate user experiente. We miss a quickstart where the user run something like: # Build from github kubectl kustomize https://github.com/kubernetes-sigs/kustomize.git/examples/helloWorld?ref=v1.0.6 | kubectl create -f
where, if it's the case the use can choose between Kubernetes and Openshift, withouth knowing anything about overlays. What I mean is that we provide 2 procedures:
- Kubernetes installation:
kubectl kustomize https://github.com/apache/camel-k.git/install/overlays/kubernetes | kubectl create -f
- Openshift installation:
kubectl kustomize https://github.com/apache/camel-k.git/install/overlays/openshift | kubectl create -f
kubectl kustomize https://github.com/apache/camel-k/kustomize/overlays/kubernetes | kubectl create -f - | ||
``` | ||
|
||
NOTE: to use a different branch add the parameter "ref" to the github repository URL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put an example like https://github.com/apache/camel-k/kustomize/overlays/kubernetes?ref=main
|
||
To run from remote github repository: | ||
```sh | ||
kubectl kustomize https://github.com/apache/camel-k/kustomize/overlays/kubernetes | kubectl create -f - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With all examples, we should specify the ref in order to point to the latest released version. We need to update the release script in order to update the documentation when we release (could be a follow up issue though).
|
||
### Minikube | ||
|
||
You can easilly configure minikube with the registry addon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We miss the instruction to enable the addon on the minikube.
First get the internal registry service IP from minikube : | ||
|
||
```sh | ||
export KAMEL_REGISTRY_ADDRESS="$(kubectl get service --selector "kubernetes.io/minikube-addons"="registry" --namespace kube-system -o=jsonpath='{.items[0].spec.clusterIP}')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For minikube we may not required this any longer. There was some development in the past to enable KEP-1755: #2696 which is, being able to detect any local registry. It would be nice to try without it and, if it works, remove the registry setting part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I will check this. This explains the "placeholder" namespace value I saw in the files.
7e8261c
to
4228297
Compare
4228297
to
7b45cbd
Compare
This PR has been automatically marked as stale due to 90 days of inactivity. |
This is an experiment to refactor and simplify kustomize installations.
I am creating this PR to check what is the impact of the removals of code.
Don't hesitate to give your feedback but keep in mind this is very much a work in progress 😸 .
Release Note