Operate on public data under Lock #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanonyme
requested review from
gtristan,
juergbi,
BenjaminSchubert,
cs-shadow and
abderrahim
as code owners
nanonyme
force-pushed
the
nanonyme/thread-safety
branch
3 times, most recently
from
9e45e5c to
5a9c655
Compare
nanonyme
force-pushed
the
nanonyme/thread-safety
branch
2 times, most recently
from
51ed94e to
f9389b7
Compare
nanonyme
force-pushed
the
nanonyme/thread-safety
branch
from
f9389b7 to
9ef2044
Compare
juergbi
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
LGTM. As I understand it, the only possible race is between multiple get/load calls and there can't ever be a race between set_public_data() and get/load (as reverse dependencies must anyway wait until the build is complete), so the lock would not actually be needed everywhere. However, guarding every access of the variable is reasonable and this should have no noticeable performance impact, so I think it's fine to merge this as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1955