-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[rocksdb]: fix error rocksdb default config for CFOptions #4466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6749e72
to
b2d4872
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job, LGTM
The change broke KeyValueStorageRocksDBTest:
|
Thanks,I will fix all failed Testcases. |
65fdbd5
to
ace833c
Compare
ace833c
to
26ee64c
Compare
I have fixed it. |
Descriptions of the changes in this PR:
Fix erros of rocksdb default config
Motivation
The default rocksdb config has some errors and need fix.
Changes