test: migrate client module api tests to junit 5 #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherlock-lin
force-pushed
the
sherlock-migrate-to-junit5-0516
branch
2 times, most recently
from
bcc59bb
to
da302e5
Compare
sherlock-lin
force-pushed
the
sherlock-migrate-to-junit5-0516
branch
from
da302e5
to
e85971e
Compare
sherlock-lin
force-pushed
the
sherlock-migrate-to-junit5-0516
branch
6 times, most recently
from
407fc29
to
f0aa9af
Compare
sherlock-lin
force-pushed
the
sherlock-migrate-to-junit5-0516
branch
from
f0aa9af
to
859af11
Compare
shoothzj
reviewed
May 25, 2024
...keeper-server/src/test/java/org/apache/bookkeeper/client/extension/TestContextExtension.java
Outdated
Show resolved
Hide resolved
lhotari
requested changes
May 29, 2024
|
@lhotari Thanks for you remind, I remember this class too, and it has been used in |
lhotari
reviewed
May 29, 2024
...-server/src/test/java/org/apache/bookkeeper/client/api/BookKeeperBuildersOpenLedgerTest.java
Outdated
Show resolved
Hide resolved
sherlock-lin
force-pushed
the
sherlock-migrate-to-junit5-0516
branch
2 times, most recently
from
8cb695d
to
2615c36
Compare
shoothzj
approved these changes
Jun 4, 2024
sherlock-lin
force-pushed
the
sherlock-migrate-to-junit5-0516
branch
from
2615c36
to
84335b9
Compare
done :) |
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/MockBookKeeperTestCase.java
Show resolved
Hide resolved
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/MockBookKeeperTestCase.java
Show resolved
Hide resolved
|
@lhotari help review，please |
|
Good work @sherlock-lin |
|
I'll close and reopen to see if it passes with latest changes in master. |
|
Thanks for your contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Fix #4322
Main Issue: #4322