Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused slf4j simpleLogger property #4321

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

shoothzj
Copy link
Member

Motivation

BookKeeper don't use slf4j simpleLogger anymore. Remove unused property.

@shoothzj
Copy link
Member Author

@nicoloboschi nicoloboschi merged commit 09a38e5 into apache:master Apr 30, 2024
21 checks passed
@shoothzj shoothzj deleted the simplelogger branch April 30, 2024 14:53
@lhotari
Copy link
Member

lhotari commented May 6, 2024

@shoothzj @nicoloboschi There's a need to do some revisits. slf4j-simple is used in integration tests. This is where this happens:

deps.add(MavenDependencies.createDependency("org.slf4j:slf4j-simple:" + slf4jVersion.get(),
ScopeType.COMPILE, false));
deps.add(MavenDependencies.createDependency("org.slf4j:jcl-over-slf4j:" + slf4jVersion.get(),
ScopeType.COMPILE, false));
.

@shoothzj
Copy link
Member Author

shoothzj commented May 6, 2024

@lhotari Thanks. It seems MavenClassLoader will load different versions of bk and unify it to slf4j-simple, but why we need this? Let me check if integrate-tests bookkeeper outputs log well later soon.

@lhotari
Copy link
Member

lhotari commented May 6, 2024

@lhotari Thanks. It seems MavenClassLoader will load different versions of bk and unify it to slf4j-simple, but why we need this? Let me check if integrate-tests bookkeeper outputs log well later soon.

It's needed for logging in integration tests. I guess log4j is avoided because of possible classloader problems.

@lhotari
Copy link
Member

lhotari commented May 6, 2024

Actually this PR seems to be fine. The simpleLogger config previously in tests/integration-tests-base-groovy/pom.xml was only used for tests/integration-tests-base-groovy. I think that the actual tests are in another project, so this config was anyways not used.

@hangc0276 hangc0276 added this to the 4.18.0 milestone May 25, 2024
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants