Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check rocksdb closed before operating #4243

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public void addLocation(long ledgerId, long entryId, long location) throws IOExc
batch.close();
}

public Batch newBatch() {
public Batch newBatch() throws IOException {
return locationsDb.newBatch();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ default void compact() throws IOException {}
*
* @return
*/
CloseableIterator<byte[]> keys();
CloseableIterator<byte[]> keys() throws IOException;

/**
* Get an iterator over to scan sequentially through all the keys within a
Expand All @@ -134,13 +134,13 @@ default void compact() throws IOException {}
* the lastKey in the range (not included)
*
*/
CloseableIterator<byte[]> keys(byte[] firstKey, byte[] lastKey);
CloseableIterator<byte[]> keys(byte[] firstKey, byte[] lastKey) throws IOException;

/**
* Return an iterator object that can be used to sequentially scan through all
* the entries in the database.
*/
CloseableIterator<Entry<byte[], byte[]>> iterator();
CloseableIterator<Entry<byte[], byte[]>> iterator() throws IOException;

/**
* Commit all pending write to durable storage.
Expand All @@ -163,7 +163,7 @@ interface CloseableIterator<T> extends Closeable {
T next() throws IOException;
}

Batch newBatch();
Batch newBatch() throws IOException;

/**
* Interface for a batch to be written in the storage.
Expand All @@ -175,7 +175,7 @@ public interface Batch extends Closeable {

void deleteRange(byte[] beginKey, byte[] endKey) throws IOException;

void clear();
void clear() throws IOException;

void flush() throws IOException;

Expand Down
Loading
Loading