Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uncontrolled data used in path expression #4221

Conversation

hangc0276
Copy link
Contributor

Motivation

We must add the filename check before doing any operations to reduce the attack risk.

Changes

Add filename check.

Master Issue: #


In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks.


Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

@merlimat merlimat merged commit 34d8515 into apache:master Mar 4, 2024
20 checks passed
nicoloboschi pushed a commit that referenced this pull request Mar 21, 2024
* Fix uncontrolled data used in path expression

* update code

* update code

(cherry picked from commit 34d8515)
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
* Fix uncontrolled data used in path expression

* update code

* update code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants