BenchReadThroughputLatency support config the way of gen ledger path. #4219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
reviewed
Feb 26, 2024
| @@ -153,6 +154,9 @@ public static void main(String[] args) throws Exception { | |||
| Options options = new Options(); | |||
| options.addOption("ledger", true, "Ledger to read. If empty, read all ledgers which come available. " | |||
| + " Cannot be used with -listen"); | |||
| //How to generate ledger id | |||
| options.addOption("genLedgerWay", true, "The way of generating ledgerId. " | |||
There was a problem hiding this comment.
Use ledgerManagerType?
bookkeeper/conf/bk_server.conf
Lines 827 to 828 in 34bd4b3
There was a problem hiding this comment.
ledgerManagerType
Make sense.
hangc0276
approved these changes
Feb 26, 2024
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
…apache#4219) ### Motivation In BenchReadThroughputLatency, it generates the ledger zk node path using `String.format("/ledgers/L%010d", ledger.get());` But if the user uses `HierarchicalLedgerManager`, `LegacyHierarchicalLedgerManager`, or `LongHierarchicalLedgerManager`, the ledger zk node path is not the same as the way in the BenchReadThroughputLatency. So we need support config the `genLedgerWay` to match the custom LedgerManager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In BenchReadThroughputLatency, it generates the ledger zk node path using
String.format("/ledgers/L%010d", ledger.get());But if the user uses
HierarchicalLedgerManager,LegacyHierarchicalLedgerManager, orLongHierarchicalLedgerManager, the ledger zk node path is not the same as the way in the BenchReadThroughputLatency.So we need support config the
genLedgerWayto match the custom LedgerManager.