Upgrade mockito from 3.12.4 to 4.11.0 #4218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
force-pushed
the
upgrade-mockito
branch
from
7e2631d
to
f0d392b
Compare
nodece
force-pushed
the
upgrade-mockito
branch
from
f0d392b
to
e9f3c6f
Compare
nodece
changed the title
merlimat
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Upgrade the mockito for better compatibility with the latest JDK.
Because mockito@5 requires the JDK 11, we can only upgrade to [email protected].
Changes
BookieCriticalThreadin theJournalandBookieImpl, because the mocktio doesn't support spying theThreadclass: Spy on Thread raise unexpected exception while stack walking mockito/mockito#2906 (comment)