AutoRecovery supports batch read #4211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
changed the title
|
@horizonzy I introduced batch reading for auto-recovery, please help take a look, thanks. |
zymap
approved these changes
Feb 20, 2024
zymap
approved these changes
Feb 20, 2024
horizonzy
reviewed
Feb 20, 2024
| } | ||
| toSend.release(); | ||
| } | ||
| if (lastEntryId == endEntryId) { |
There was a problem hiding this comment.
When lastEntryId == endEntryId, we needn't callback ledgerFragmentMcb.processResult(BKException.Code.OK, null, null);.
There was a problem hiding this comment.
Good point! Updated
horizonzy
reviewed
Feb 20, 2024
| LOG.error("BK error reading ledger entries: {} - {}", | ||
| startEntryId, endEntryId, BKException.create(rc)); | ||
| onReadEntryFailureCallback.accept(lh.getId(), startEntryId); | ||
| ledgerFragmentMcb.processResult(rc, null, null); |
There was a problem hiding this comment.
The ledgerFragmentMcb is MultiCallback, when batch read fails, the processResult invoke count may be not enough.
There was a problem hiding this comment.
Good point. Updated.
merlimat
approved these changes
Feb 20, 2024
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
* AutoRecovery support batch read * Fix check style * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We support batch reading in BP-62 and auto-recovery is the best case to support this feature. This PR supports batch reading for auto-recovery and introduces a flag
recoveryBatchReadEnabledto enable batch reading for auto-recoveryChanges
We introduce a flag
recoveryBatchReadEnabledto enable batch reading for auto-recovery.