Issue 2161: set metrics endpoint content-type #4208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
approved these changes
Feb 9, 2024
shoothzj
approved these changes
Feb 11, 2024
hangc0276
approved these changes
Feb 21, 2024
bookkeeper-server/src/main/java/org/apache/bookkeeper/server/http/service/MetricsService.java
Show resolved
Hide resolved
eolivelli
requested changes
Mar 5, 2024
bookkeeper-server/src/main/java/org/apache/bookkeeper/server/http/service/MetricsService.java
Outdated
Show resolved
Hide resolved
added 2 commits
March 5, 2024 15:34
|
@eolivelli Would you please review this PR again? Thanks. |
nicoloboschi
pushed a commit
that referenced
this pull request
Mar 21, 2024
* fix: set metrics endpoint content-type when bookie http server is enabled * fix: checkstyle * fix: use existing prometheus content type constant * chore: use minimal dependency / license fixes * Revert "chore: use minimal dependency / license fixes" This reverts commit 7daf8be. * Revert "fix: use existing prometheus content type constant" This reverts commit c265c49. (cherry picked from commit 382184e)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
* fix: set metrics endpoint content-type when bookie http server is enabled * fix: checkstyle * fix: use existing prometheus content type constant * chore: use minimal dependency / license fixes * Revert "chore: use minimal dependency / license fixes" This reverts commit 7daf8be. * Revert "fix: use existing prometheus content type constant" This reverts commit c265c49.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #2161
Changes
Add contentType to HttpServiceResponse and map it in VertxAbstractHandler which allows
MetricsService (which is used instead of PrometheusServlet when bookie http server is enabled) to set the http Content-Type header to the right value which allow successful scraping of the endpoint by e.g. New Relic
Master Issue: #2161