Fix NoSuchElementException when rereplicate empty ledgers #4039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aloyszhang
approved these changes
Aug 2, 2023
|
@hangc0276 @zymap PTAL |
hangc0276
reviewed
Aug 9, 2023
There was a problem hiding this comment.
Nice catch. @chenhongSZ Would you please add a test to cover this change? thanks.
done, PTAL |
wenbingshen
reviewed
Sep 6, 2023
Comment on lines
296
to
298
| long numberOfEntriesToReplicate = firstEntryId == INVALID_ENTRY_ID && lastEntryId == INVALID_ENTRY_ID ? 0 : | ||
| (lastEntryId - firstEntryId) + 1; | ||
| long splitsWithFullEntries = numberOfEntriesToReplicate |
There was a problem hiding this comment.
Can you share the configuration of replicationEntryBatchSize in the bookie server?
If I understand correctly, this problem will only occur when replicationEntryBatchSize=1
There was a problem hiding this comment.
Your understanding is correct. Our configuration is rereplicationEntryBatchSize=1
hangc0276
approved these changes
Sep 6, 2023
| @@ -293,7 +293,8 @@ static Set<LedgerFragment> splitIntoSubFragments(LedgerHandle lh, | |||
| assert false; | |||
| } | |||
|
|
|||
| long numberOfEntriesToReplicate = (lastEntryId - firstEntryId) + 1; | |||
| long numberOfEntriesToReplicate = firstEntryId == INVALID_ENTRY_ID && lastEntryId == INVALID_ENTRY_ID ? 0 : | |||
There was a problem hiding this comment.
We can simplify the condition to long numberOfEntriesToReplicate = firstEntryId == INVALID_ENTRY_ID ? 0 : (lastEntryId - firstEntryId) + 1;
aloyszhang
approved these changes
Sep 20, 2023
wenbingshen
approved these changes
Sep 20, 2023
zymap
pushed a commit
that referenced
this pull request
Dec 7, 2023
hangc0276
pushed a commit
to hangc0276/bookkeeper
that referenced
this pull request
Jan 18, 2024
### Motivation Master issue: apache#4036 ### Changes Set the `numberOfEntriesToReplicate` to 0 when ledger is empty (cherry picked from commit 95320f4)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
### Motivation Master issue: apache#4036 ### Changes Set the `numberOfEntriesToReplicate` to 0 when ledger is empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Master issue: #4036
Changes
Set the
numberOfEntriesToReplicateto 0 when ledger is empty