reverted try-with-resources for FileChannel

apache · Jul 1, 2024 · 69cb849 · 69cb849
1 parent 3030303
commit 69cb849
Showing 1 changed file with 13 additions and 14 deletions.
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLoggerAllocator.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLoggerAllocator.java
@@ -180,24 +180,23 @@ private synchronized BufferedLogChannel allocateNewLog(File dirForNextEntryLog,
         } while (testLogFile == null);
 
         File newLogFile = new File(dirForNextEntryLog, logFileName);
-        try (FileChannel channel = new RandomAccessFile(newLogFile, "rw").getChannel()) {
+        FileChannel channel = new RandomAccessFile(newLogFile, "rw").getChannel();
 
-            BufferedLogChannel logChannel = new BufferedLogChannel(byteBufAllocator, channel, conf.getWriteBufferBytes(),
-                    conf.getReadBufferBytes(), preallocatedLogId, newLogFile, conf.getFlushIntervalInBytes());
-            logfileHeader.readerIndex(0);
-            logChannel.write(logfileHeader);
+        BufferedLogChannel logChannel = new BufferedLogChannel(byteBufAllocator, channel, conf.getWriteBufferBytes(),
+                conf.getReadBufferBytes(), preallocatedLogId, newLogFile, conf.getFlushIntervalInBytes());
+        logfileHeader.readerIndex(0);
+        logChannel.write(logfileHeader);
 
-            for (File f : ledgersDirs) {
-                setLastLogId(f, preallocatedLogId);
-            }
-
-            if (suffix.equals(DefaultEntryLogger.LOG_FILE_SUFFIX)) {
-                recentlyCreatedEntryLogsStatus.createdEntryLog(preallocatedLogId);
-            }
+        for (File f : ledgersDirs) {
+            setLastLogId(f, preallocatedLogId);
+        }
 
-            log.info("Created new entry log file {} for logId {}.", newLogFile, preallocatedLogId);
-            return logChannel;
+        if (suffix.equals(DefaultEntryLogger.LOG_FILE_SUFFIX)) {
+            recentlyCreatedEntryLogsStatus.createdEntryLog(preallocatedLogId);
         }
+
+        log.info("Created new entry log file {} for logId {}.", newLogFile, preallocatedLogId);
+        return logChannel;
     }