Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not fail the job when submission_environment_dependencies.txt cannot be loaded #32752

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Do not fail the job when submission_environment_dependencies.txt cannot be loaded #32752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion sdks/python/container/boot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,12 @@ func launchSDKProcess() error {
fmtErr := fmt.Errorf("failed to retrieve staged files: %v", err)
// Send error message to logging service before returning up the call stack
logger.Errorf(ctx, fmtErr.Error())
return fmtErr
// No need to fail the job if submission_environment_dependencies.txt cannot be loaded
if strings.Contains(fmtErr.Error(), "submission_environment_dependencies.txt") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should instead root cause what happens with materialization hare. as mentioned on GH issue, there is a workaround we can recommend now to skip staging submission environment. It is possible that all materialization is broken. does supplying --extra_package / --save_main_session work?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to create another github issue to check this. My goal is to get this working with FlinkRunner on Dataproc now.

logger.Printf(ctx, "Ignore the error when loading submission_environment_dependencies.txt.")
} else {
return fmtErr
}
}

// TODO(herohde): the packages to install should be specified explicitly. It
Expand Down
Loading