Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#32139] Fail pipelines with Stateful SDFs. #32140

Merged
merged 2 commits into from
Aug 9, 2024
Merged

[#32139] Fail pipelines with Stateful SDFs. #32140

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db3cdfa
[#32139] Fail pipelines with Stateful SDFs.
lostluck Aug 9, 2024
5a6a97b
rm debug print
lostluck Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions sdks/go/pkg/beam/runners/prism/internal/jobservices/management.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,17 +158,26 @@ func (s *Server) Prepare(ctx context.Context, req *jobpb.PrepareJobRequest) (*jo
return nil, fmt.Errorf("unable to unmarshal ParDoPayload for %v - %q: %w", tid, t.GetUniqueName(), err)
}

isStateful := false

// Validate all the state features
for _, spec := range pardo.GetStateSpecs() {
isStateful = true
check("StateSpec.Protocol.Urn", spec.GetProtocol().GetUrn(), urns.UserStateBag, urns.UserStateMultiMap)
}
// Validate all the timer features
for _, spec := range pardo.GetTimerFamilySpecs() {
isStateful = true
check("TimerFamilySpecs.TimeDomain.Urn", spec.GetTimeDomain(), pipepb.TimeDomain_EVENT_TIME, pipepb.TimeDomain_PROCESSING_TIME)
}

check("OnWindowExpirationTimerFamily", pardo.GetOnWindowExpirationTimerFamilySpec(), "") // Unsupported for now.

// Check for a stateful SDF and direct user to https://github.com/apache/beam/issues/32139
if pardo.GetRestrictionCoderId() != "" && isStateful {
check("Splittable+Stateful DoFn", "See https://github.com/apache/beam/issues/32139 for information.", "")
}

case urns.TransformTestStream:
var testStream pipepb.TestStreamPayload
if err := proto.Unmarshal(t.GetSpec().GetPayload(), &testStream); err != nil {
Expand Down
Loading