-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RRIO] [Call] Implement the Repeater #29490
Conversation
f73bde8
to
0c6a976
Compare
Assigning reviewers. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, had a couple of comments regarding the on using beam builtin core util and dependencies.
sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Repeater.java
Outdated
Show resolved
Hide resolved
sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Repeater.java
Outdated
Show resolved
Hide resolved
sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Repeater.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* [RRIO] [Call] Implement the Repeater * Define repeatable exception types * Tests validate expected errors * Refactor per PR comments
This PR closes #28926 by:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.