Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RRIO] [Call] Implement the Repeater #29490

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

damondouglas
Copy link
Contributor

@damondouglas damondouglas commented Nov 19, 2023

This PR closes #28926 by:

  • Defining a Repeater interface
  • Implementing a default Repeater implementation using exponential backoff

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damondouglas damondouglas marked this pull request as ready for review November 27, 2023 20:54
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @Abacn for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, had a couple of comments regarding the on using beam builtin core util and dependencies.

@damondouglas damondouglas marked this pull request as draft November 30, 2023 01:20
@damondouglas damondouglas marked this pull request as ready for review December 1, 2023 21:19
Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damondouglas damondouglas merged commit 40685cd into apache:master Dec 5, 2023
21 checks passed
@damondouglas damondouglas deleted the rrio-repeater branch December 5, 2023 20:45
Naireen pushed a commit to Naireen/beam that referenced this pull request Jan 3, 2024
* [RRIO] [Call] Implement the Repeater

* Define repeatable exception types

* Tests validate expected errors

* Refactor per PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: [RRIO] [Call] Repeater invokes functional interfaces with in-between throttling
2 participants